Adjust license for package uploaded to PyPI #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
JeanChristopheMorinPerso
force-pushed
the
update_pypi_license
branch
from
d861dce
to
cf8a2d2
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1598 +/- ##
=======================================
Coverage 79.91% 79.91%
=======================================
Files 197 197
Lines 21731 21731
Branches 4339 4339
=======================================
Hits 17366 17366
Misses 2213 2213
Partials 2152 2152
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
apetrynet
reviewed
May 20, 2023
Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com>
meshula
approved these changes
May 20, 2023
|
@meshula Note that the license will be reported correctly. The note about the classifier is really just for classifiers. They are used to filter packages on PyPI. But our Apache 2.0 license will be reported correctly in the package Metadata and in the UI. |
jminor
approved these changes
May 22, 2023
MichaelPlug
pushed a commit
to MichaelPlug/OpenTimelineIO
that referenced
this pull request
Aug 5, 2023
…n#1598) * Adjust license for package uploaded to PyPI * Don't set license_file Signed-off-by: Jean-Christophe Morin <jean_christophe_morin@hotmail.com> Signed-off-by: Michele Spina <michelespina96@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that our package in PyPI was still advertising the old license (Modified Apache 2.0). So this PR fixes that to make sure. Our next release will now correctly show Apache 2.0.