Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non latin symbols decoding in adapters #1691

Merged
merged 1 commit into from Mar 14, 2024

Conversation

kalemas
Copy link
Contributor

@kalemas kalemas commented Feb 1, 2024

Link the Issue(s) this Pull Request is related to.

Fixes #1321

Summarize your change.

As Py2 support is dropped we should be free to commit utf-8 encoding in Python Adapters to handle UTF in input data.

Copy link

linux-foundation-easycla bot commented Feb 1, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kalemas / name: Konstantin Maslyuk (cfeb904)

@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (013fe04) 79.83% compared to head (cfeb904) 79.83%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1691   +/-   ##
=======================================
  Coverage   79.83%   79.83%           
=======================================
  Files         197      197           
  Lines       21814    21814           
  Branches     4362     4362           
=======================================
  Hits        17416    17416           
  Misses       2233     2233           
  Partials     2165     2165           
Flag Coverage Δ
py-unittests 79.83% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...-opentimelineio/opentimelineio/adapters/adapter.py 89.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 013fe04...cfeb904. Read the comment docs.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the contribution.

@reinecke
Copy link
Collaborator

@kalemas We've addressed the windows build issues in the HEAD of the current main branch, would you mind rebasing on top of that so we can get a clean build?
Sorry about the confusion!

Signed-off-by: Konstantin <kostyamaslyuk@gmail.com>
@kalemas
Copy link
Contributor Author

kalemas commented Feb 17, 2024

rebasing on top of that so we can get a clean build?

@reinecke Done.

@reinecke reinecke merged commit 383fcdd into AcademySoftwareFoundation:main Mar 14, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FCP7 XML adapter issue: Py 3.9 changes default encoding behavior on 'open'
4 participants