Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated issue and PR templates to be a bit more approachable #1700

Merged

Conversation

reinecke
Copy link
Collaborator

Summarize your change.

Simplified issue template to be more approachable. Also modified wording in the PR template so users won't feel obligated to create an issue for a PR if one didn't exist already.

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d22935e) 79.84% compared to head (56174f0) 79.83%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1700      +/-   ##
==========================================
- Coverage   79.84%   79.83%   -0.01%     
==========================================
  Files         197      197              
  Lines       21796    21814      +18     
  Branches     4358     4362       +4     
==========================================
+ Hits        17403    17416      +13     
- Misses       2232     2233       +1     
- Partials     2161     2165       +4     
Flag Coverage Δ
py-unittests 79.83% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d22935e...56174f0. Read the comment docs.

Copy link
Collaborator

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together!

Copy link
Contributor

@apetrynet apetrynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this simplified template. Have a couple of minor suggestions.

.github/ISSUE_TEMPLATE.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE.md Show resolved Hide resolved
meshula and others added 2 commits February 15, 2024 09:50
Co-authored-by: Daniel Flehner Heen <flehnerheener@gmail.com>
Signed-off-by: Nick Porcino <meshula@hotmail.com>
Co-authored-by: Daniel Flehner Heen <flehnerheener@gmail.com>
Signed-off-by: Nick Porcino <meshula@hotmail.com>
.github/ISSUE_TEMPLATE.md Outdated Show resolved Hide resolved
Co-authored-by: Daniel Flehner Heen <flehnerheener@gmail.com>
Signed-off-by: Nick Porcino <meshula@hotmail.com>
.github/ISSUE_TEMPLATE.md Outdated Show resolved Hide resolved
Co-authored-by: Daniel Flehner Heen <flehnerheener@gmail.com>
Signed-off-by: Nick Porcino <meshula@hotmail.com>
Copy link
Contributor

@apetrynet apetrynet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Looks good to me.

@meshula meshula merged commit 4c17494 into AcademySoftwareFoundation:main Feb 19, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants