Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macos-14 arm64 runners #1739

Merged

Conversation

markreidvfx
Copy link
Contributor

This PR adds macOS arm64 runners for #1672

The only issue I'm facing is python 3.8 and 3.9 aren't working with the current setup-python action.
actions/setup-python#696

Wheels can still be made, python 3.8 and 3.9 are supported with the cibuildwheel action.

python-3.9 is the version of python included on macOS, so its annoying the test aren't running.

As for python-3.7, it was never supported for apple silicon as far as I understand.

Signed-off-by: Mark Reid <mindmark@gmail.com>
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.11%. Comparing base (2b9c3a4) to head (7e687fe).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1739      +/-   ##
==========================================
+ Coverage   79.95%   84.11%   +4.16%     
==========================================
  Files         197      198       +1     
  Lines       21879    22241     +362     
  Branches     4342     4689     +347     
==========================================
+ Hits        17494    18709    +1215     
- Misses       2252     2610     +358     
+ Partials     2133      922    -1211     
Flag Coverage Δ
py-unittests 84.11% <ø> (+4.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 107 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d875e7...7e687fe. Read the comment docs.

@JeanChristopheMorinPerso JeanChristopheMorinPerso linked an issue Apr 14, 2024 that may be closed by this pull request
@meshula meshula merged commit c0e97b0 into AcademySoftwareFoundation:main Apr 14, 2024
54 checks passed
@meshula
Copy link
Collaborator

meshula commented Apr 14, 2024

Hi @JeanChristopheMorinPerso @markreidvfx The CI passed on this PR, so I merged it. However, the runners "in real life" are failing now that it's merged. Any idea what's going on?

@markreidvfx
Copy link
Contributor Author

looks like a timeout of some kind with ssl. Retrying the job I think might fix it

  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/ssl.py", line 1042, in _create
      self.do_handshake()
    File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/ssl.py", line 1320, in do_handshake
      self._sslobj.do_handshake()
  TimeoutError: [Errno 60] Operation timed out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Apple Silicon/ARM wheels
3 participants