Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a weakref for _parent to prevent cycles. #364

Merged
merged 1 commit into from Nov 9, 2018

Conversation

ssteinbach
Copy link
Collaborator

The _parent pointer should be a weakref. This also enforces that nothing outside of item should use the _parent pointer directly, things should go through .parent()

@jminor jminor merged commit fec780c into AcademySoftwareFoundation:master Nov 9, 2018
@reinecke
Copy link
Collaborator

reinecke commented Nov 9, 2018

Nice catch! I wonder if we might be able to work some profiling visibility into our CI pipeline. There are some interesting puzzle pieces available:

We'd still need to do something with the data, however.

@ssteinbach
Copy link
Collaborator Author

@reinecke if you can find a service (like codecov for coverage) that can present the data and is free for open source projects, we'd be happy to discuss integrating more metrics. As we move to C++ having static analysis be part of the PR would be pretty cool.

alatdneg pushed a commit to alatdneg/OpenTimelineIO that referenced this pull request Nov 13, 2018
flavienliger pushed a commit to flavienliger/OpenTimelineIO that referenced this pull request Nov 14, 2018
@jminor jminor added this to To Do in C++ API via automation Nov 15, 2018
@ssteinbach ssteinbach moved this from To Do to Done in C++ API Nov 21, 2018
@ssteinbach ssteinbach deleted the weakref_parent branch September 23, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
C++ API
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants