Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix N^2 (over items) performance in otioview _populate #422

Merged

Conversation

ssteinbach
Copy link
Collaborator

  • We added the range_of_all_children method for exactly this use case- it was missing here
  • This significantly improves performance of reading large files into otioview

- We added the range_of_all_children method for exactly this use case- it was missing here
- This _significantly_ improves performance of reading large files into otioview
@ssteinbach ssteinbach added this to the Public Beta 10 milestone Feb 9, 2019
@codecov-io
Copy link

codecov-io commented Feb 9, 2019

Codecov Report

Merging #422 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #422   +/-   ##
=======================================
  Coverage   86.85%   86.85%           
=======================================
  Files          63       63           
  Lines        5608     5608           
=======================================
  Hits         4871     4871           
  Misses        737      737

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 125191d...4e78e9a. Read the comment docs.

@jminor jminor merged commit 4201bbe into AcademySoftwareFoundation:master Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants