New feature implementation of writing AAF files from otio files in the AAF adapter #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freesonluxo
force-pushed
the
aaf_writer
branch
from
52435c1
to
3c9c810
Compare
freesonluxo
changed the title
This comment has been minimized.
This comment has been minimized.
freesonluxo
commented
Feb 25, 2019
Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com>
Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com>
Co-author-by: Shahbaz Khan <shahbazk@pixar.com>
Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com>
with moving ownership of compositionmob to the AAFFileTranscriber class Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com>
Also conforming to pep8. Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com>
["Length"] instead of duration. We really should look into this bug. Right now working around. Using soft gets in aaf_transition() in places where we might not have values. Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com>
removing the point_list check in aaf_transition() Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com>
This commit should be relatively clean. Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com>
Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com>
- clean up comments - functionilized descriptors into base class - fixing exceptions, raising stricter exceptions Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com>
- Transition type checking - Rename aaf_file_transcriber to root_file_transcriber - Rename precheck to validate_metadata and made a free function Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com
Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com
Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com>
Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com>
Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
==========================================
+ Coverage 86.52% 87.15% +0.63%
==========================================
Files 66 67 +1
Lines 6233 6734 +501
==========================================
+ Hits 5393 5869 +476
- Misses 840 865 +25
Continue to review full report at Codecov.
|
Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com>
Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com>
ssteinbach
requested changes
Mar 5, 2019
| """Get a unique tapemob, identified by clip metadata mob id.""" | ||
| mob_id = otio_clip.metadata["AAF"]["SourceID"] | ||
| tape_mob = self._unique_tapemobs.get(mob_id) | ||
| if not tape_mob: |
There was a problem hiding this comment.
Inverting this would allow you to dedent the block and make the else condition more clear:
if tape_mob:
return tape_mob
...| # Currently, we only support clips that are already in Avid with a mob ID | ||
| mob_id = otio_clip.metadata["AAF"]["SourceID"] | ||
| master_mob = self._unique_mastermobs.get(mob_id) | ||
| if not master_mob: |
There was a problem hiding this comment.
Inverting this could also make it more readable (see next comment).
_TrackTranscriber. Additional comments. Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com>
ssteinbach
approved these changes
Mar 6, 2019
ssteinbach
pushed a commit
that referenced
this pull request
Mar 6, 2019
…e AAF adapter (#432) Initial commit of OTIO->AAF Writer from @freesonluxo and @shahbazk8194 . Co-authored-by: Shahbaz Khan <shahbazkhan8194@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial implementation of the AAF writer in AAF adapter.
Co-authored-by: Shahbaz Khan shahbazkhan8194@gmail.com