AAF writer: Adding support for audio transitions

[shahbazk8194]

Creating abstract method _transition_parameters that is called in _TrackTranscriber.aaf_transition to support both video and audio transitions

side note: Using metadata clip length instead of duration() in aaf_sourceclip. We'll fix this later

Co-authored-by: Freeson Wang freeson@pixar.com

[codecov-io]

Codecov Report

Merging #454 into master will increase coverage by <.01%.
The diff coverage is 96.96%.

@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
+ Coverage   87.16%   87.17%   +<.01%     
==========================================
  Files          67       67              
  Lines        6788     6799      +11     
==========================================
+ Hits         5917     5927      +10     
- Misses        871      872       +1

Impacted Files	Coverage Δ
...neio_contrib/adapters/advanced_authoring_format.py	90.57% <ø> (-0.05%)	⬇️
...elineio_contrib/adapters/tests/test_aaf_adapter.py	98.08% <100%> (ø)	⬆️
...elineio_contrib/adapters/aaf_adapter/aaf_writer.py	93.6% <96.87%> (-0.06%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d6c8ce...2ebba59. Read the comment docs.

[ssteinbach]

Looks good to me, thanks!

[stefanschulze]

Code looks good to me. Only thing my mind was hesitating for a sec. is the self.media_kind usage in the aaf_transition method. When is it set? And is it context-sensitive, i.e. changes per transition type?

[jminor]

This looks good. My only concern is the use of metadata["AAF"]["Length"] instead of duration().value. Do you know what the issue in the reader is? Is there an open issue for that?

[shahbazk8194]

@jminor We don't know what the issue is regarding why the duration().value. There is an issue for that. It is issue #438

I imagine it would be a small change to the reader. We plan on tackling that along side the work that's happening to reduce metadata coupling throughout the writer