Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support nesting for AAF writer #461

Merged
merged 8 commits into from
Apr 1, 2019
Merged

Support nesting for AAF writer #461

merged 8 commits into from
Apr 1, 2019

Conversation

shahbazk8194
Copy link
Contributor

Co-authored-by: Freeson Wang freeson@pixar.com

@codecov-io
Copy link

codecov-io commented Mar 18, 2019 •
edited

Codecov Report

Merging #461 into master will increase coverage by 0.06%.
The diff coverage is 93.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #461      +/-   ##
==========================================
+ Coverage   88.02%   88.08%   +0.06%     
==========================================
  Files          68       68              
  Lines        6838     6881      +43     
==========================================
+ Hits         6019     6061      +42     
- Misses        819      820       +1
Impacted Files Coverage Δ
...elineio_contrib/adapters/tests/test_aaf_adapter.py 98.26% <100%> (+0.02%) ⬆️
...neio_contrib/adapters/advanced_authoring_format.py 91.15% <100%> (+0.5%) ⬆️
...elineio_contrib/adapters/aaf_adapter/aaf_writer.py 95.22% <92.45%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 274eb32...c4ed3ec. Read the comment docs.

Shahbaz Khan and others added 6 commits March 27, 2019 11:01
Shahbaz Khan and others added 2 commits April 1, 2019 10:46
jminor
jminor approved these changes Apr 1, 2019
View reviewed changes
Copy link
Collaborator

@jminor jminor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.

@ssteinbach ssteinbach added this to To do in AAF Adapter via automation Apr 1, 2019
@ssteinbach ssteinbach added this to the Public Beta 10 milestone Apr 1, 2019
AAF Adapter automation moved this from To do to In progress Apr 1, 2019
ssteinbach
ssteinbach approved these changes Apr 1, 2019
View reviewed changes
Copy link
Collaborator

@ssteinbach ssteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! AAF writer is really coming along!

@ssteinbach ssteinbach merged commit 5352c91 into AcademySoftwareFoundation:master Apr 1, 2019
AAF Adapter automation moved this from In progress to Done Apr 1, 2019
This was referenced Apr 3, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssteinbach ssteinbach ssteinbach approved these changes

@jminor jminor jminor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OTIO - AAF Adapter
Status: Done
AAF Adapter
  
Done
Milestone
Public Beta 10
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shahbazk8194 @codecov-io @ssteinbach @jminor