Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAF Writer: Fixes the crash seen when running otio -> aaf, in some AAF files due to nesting #493

Merged
merged 5 commits into from
Apr 29, 2019

Conversation

freesonluxo
Copy link
Contributor

This makes sure that all nested groups are in stacks, then proceeds to do the nesting correctly. Roughly

otio.schema.Stack = AAF Operation Group
otio.schema.Track = AAF Sequence

@jminor
Copy link
Collaborator

jminor commented Apr 16, 2019

How does the AAF NestedScope object relate to this? I would have expected to see it in there somewhere.

@freesonluxo freesonluxo marked this pull request as ready for review April 25, 2019 23:14
@codecov-io
Copy link

codecov-io commented Apr 25, 2019

Codecov Report

Merging #493 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage    88.3%   88.37%   +0.06%     
==========================================
  Files          68       68              
  Lines        6946     6969      +23     
==========================================
+ Hits         6134     6159      +25     
+ Misses        812      810       -2
Impacted Files Coverage Δ
...neio_contrib/adapters/advanced_authoring_format.py 93.41% <100%> (+0.01%) ⬆️
...elineio_contrib/adapters/tests/test_aaf_adapter.py 98.41% <100%> (ø) ⬆️
...elineio_contrib/adapters/aaf_adapter/aaf_writer.py 95.98% <100%> (+0.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b044e07...c33ea41. Read the comment docs.

…xing nested aaf test checking now that we are stackifying
@jminor jminor merged commit 88ceece into AcademySoftwareFoundation:master Apr 29, 2019
ssteinbach pushed a commit to ssteinbach/OpenTimelineIO that referenced this pull request Jun 20, 2019
When writing AAF Sequences, make sure each one is nested inside a Submaster OperationGroup.
@ssteinbach ssteinbach added this to the Public Beta 11 milestone Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants