New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example RV OTIO reading application plugin #565
Example RV OTIO reading application plugin #565
Conversation
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
=========================================
- Coverage 81.61% 81.6% -0.01%
=========================================
Files 72 72
Lines 2730 2729 -1
=========================================
- Hits 2228 2227 -1
Misses 502 502
Continue to review full report at Codecov.
|
Hi, my name is Eric Desruisseaux, I am a SW developer at Autodesk. I am very happy to see this PR, good job! I think the approach makes great sense. I have a few questions.
Again, great work, this is very nice! Eric |
Another question :
|
Yes, |
Exactly, there is this code:
That'll have the plugin only "wake up" when it sees extensions that OTIO supports. There is an interesting question though of who would "win" in the case where there is any overlap with other supported extensions from other plugins or the built in file reading logic since this is not using the standard way file format plugins work. |
@eric-desruisseaux-adsk here are responses to your numbered questions:
|
Thanks @jminor for your answers!
At some point (unrelated to this RV package) it would be nice to have a discussion on what would be the best way to make this data OTIO standard. |
Which relates to the discussion we had previously in representing position and size in a universal coordinate system. |
Yes, we'd like to hear more details about your universal coordinate system. Are you available to discuss at our next OTIO Technical Steering Committee meeting (video conf) Sept 26th? Separate from that, do you see any of items 1-6 as blockers to accepting this PR, or smaller changes that should be addressed? You should be able to check out @avrata's branch to try it yourself. |
I already checked it out and played with it in RV, I tried it with our OTIO and it worked well, except of course for all the missing private schemas. The only thing that I think should be added (now or in a follow-up) is the support of the metadata on all nodes (as expected based on the OTIO spec). The rest was more some curiosity/question I had. Thanks! Eric |
Great. @avrata is going to look at the metadata support. |
…eIO into rv_application_plugin
I took a quick pass at adding metadata to each rv node if the associated otio item has any here: f7af52c If this looks interesting I can look into trying to update the external rv adapter with this same pattern as well. I did change the property location of the RV metadata with this a little to something that made more sense to me ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks @avrata. I had two really small questions.
...ntimelineio_contrib/application_plugins/rv/example_otio_reader/example_otio_reader_plugin.py
Show resolved
Hide resolved
...ntimelineio_contrib/application_plugins/rv/example_otio_reader/example_otio_reader_plugin.py
Show resolved
Hide resolved
Thanks @avrata! |
Re-creating #395 as an example RV plugin for loading an OTIO file into the current RV context.