Added support for ImageSequenceReference to example RV plugin #637
Conversation
Codecov Report
@@ Coverage Diff @@
## imagesequence #637 +/- ##
==============================================
Coverage 83.04% 83.04%
==============================================
Files 74 74
Lines 2860 2860
==============================================
Hits 2375 2375
Misses 485 485
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks for updating! Would it be possible to add a unittest to test it against the test data @apetrynet added?
contrib/opentimelineio_contrib/application_plugins/rv/example_otio_reader/otio_reader.py
Outdated
Show resolved
Hide resolved
contrib/opentimelineio_contrib/application_plugins/rv/example_otio_reader/otio_reader.py
Outdated
Show resolved
Hide resolved
|
re: unit test. Sure, I can try and set that up. It's a bit challenging as it'll need a bunch of tooling to build and deploy this plugin as well as run RV. I'll talk to @jminor to see if he has any good ideas. |
|
Since testing became a larger project, we're going to merge this PR in and let tests for |
* Added support for ImageSequenceReference to the example OTIO RV reader plugin * Removed debug print * Switched to using opentime.to_frames to compute rv's in and out frames Co-authored-by: Robyn Rindge <rnr@pixar.com>
* Initial implementation of ImageSequenceReference (#602) Added ImageSequenceReference MediaReference subclass schema. * Implement ImageSequenceReference in extern_rv (#633) * Added support for ImageSequenceReference to example RV plugin (#637) * Added support for ImageSequenceReference to the example OTIO RV reader plugin * Switched to using opentime.to_frames to compute rv's in and out frames Co-authored-by: Daniel Flehner Heen <flehnerheener@gmail.com> Co-authored-by: Robyn Rindge <rnr@pixar.com>
This syncs the example OTIO reader plugin with the recent changes in the RV adapter wrt support for the ImageSequenceReference schema