Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation on read the docs #715

Conversation

ssteinbach
Copy link
Collaborator

@ssteinbach ssteinbach commented May 21, 2020

It turns out that we needed to add the "recommonmark" plugin to our plugins in sphinx to get the code blocks to get rendered correctly from markdown files.

  • Also add code language annotations to code blocks in the documentation
  • Fix the formatting on some of the examples

The bug this fixes is the table of contents looking like this:
Screen Shot 2020-05-21 at 3 26 15 PM

(note all the { in the table of contents)

For a preview of this, see:
https://opentimelineio-ssteinbach.readthedocs.io/en/documentation_busted_rtd/

- also include faster direct sphinx call in Makefile in
  case people want to skip tox.
- on python 3, the code blocks in markdown files were failing, this
  makes them work again.
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #715 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #715   +/-   ##
=======================================
  Coverage   81.88%   81.88%           
=======================================
  Files          72       72           
  Lines        2755     2755           
=======================================
  Hits         2256     2256           
  Misses        499      499           
Flag Coverage Δ
#py27 81.86% <ø> (ø)
#py36 81.86% <ø> (ø)
#py37 81.86% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c61d309...264eae6. Read the comment docs.

@ssteinbach ssteinbach added this to the Public Beta 13 milestone May 21, 2020
@ssteinbach ssteinbach merged commit 995f101 into AcademySoftwareFoundation:master May 22, 2020
@ssteinbach ssteinbach deleted the documentation_busted_rtd branch May 22, 2020 17:57
@jminor jminor added this to In progress in Documentation via automation Oct 12, 2020
@jminor jminor moved this from In progress to Done in Documentation Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants