AAF Reader Metadata #739
Merged
AAF Reader Metadata #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 24, 2020 15:51
update pyaaf2 pin to use 1.4.0 (latest pyaaf2 release). This contains some important fixes (like understanding the pulldown AAF object) required for some upcoming AAF Reader changes.
…only do 1-pass transcribe. This change to the AAF reader is mainly motivated by discovering relevant metadata from clips for some (special) case scenarios which have not been covered by the current code. When traversing the AAF object-tree, at the point we reach a SourceClip, we try to discover the masterMob to then extract the metadata (UserComments) from the MasterMob. The way we discover the MasterMob is that either the referenced mob in the SourceClip is the masterMob or we walk pack the parent-chain to find the masterMob. However, there is an additional case, where the SourceClip can reference a CompositionMob which then references the masterMob. This was first discovered in one of our AAFs using subclips. This aaf-reader-update now includes this CompositionMob discovery, so when subclips are used, the expected UserComments metadata is discovered properly. In addition to this discovery there are two more scenarios: The SourceClip can reference a CompositionMob, but instead of holding a masterMob, the CompositionMob itself told the UserComments. I believe this is a way AVID realizes sharing of the same metadata between SourceClips. The SourceClip can reference a CompositionMob with UserComments AND hold a MasterMob. In this case the MasterMob seems to represent the valid UserComments, so in this scenario, we use the UserComments of the MasterMob. I added three test-cases for the scenarios described above: test_aaf_subclip_metadata() test_aaf_composition_metadata() test_aaf_composition_metadata_mastermob() In addition I added another debug flag, transcribe_debug. If enabled, it will output the recursive traversal of _transcribe(). This is helpful in order to see and understand the traversal-process. Finally I removed the first transcribe-pass and instead of building up a cache of MasterMobs, transcribe the MasterMob in the second pass 'on-demand'. Since the first pass used to transcribe any AAF object (and then basically threw away the results) this improves the time it takes to parse the AAF by a fairly large number (around 30-40%)
jminor
requested changes
Jun 25, 2020
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
contrib/opentimelineio_contrib/adapters/tests/test_aaf_adapter.py
Outdated
Show resolved
Hide resolved
ssteinbach
requested changes
Jun 25, 2020
There was a problem hiding this comment.
I left notes suggesting we push some of the formatting towards pep8. I guess one question for the room is whether we want debugging code in the library (like transcribe_log -- is there a way to turn this on with an adapter argument? If not then I'd rather prune it. If there is, then we should include it).
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
contrib/opentimelineio_contrib/adapters/advanced_authoring_format.py
Outdated
Show resolved
Hide resolved
jminor
requested changes
Jun 26, 2020
|
|
|
Oh, you're right. I was going by this documentation which says it was introduced in 3.1: https://docs.python.org/3/library/unittest.html |
jminor
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.