Kdenlive linear timewarp #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a .prproj using my otio-premiereproject adapter to .kdenlive and then opening in Kdenlive.
…miereproject on read, if anywhere). Reverted offsetting all time to 0 (I think Kdenlive either does or should handle that).
…w matches algorithm from mlt source code (haven't properly looked into it, but it's possible Python's str(datetime.timedelta(...)) is broken). Correctly uses end_time_inclusive when writing time ranges - and equivalent when reading. Converts file:/// uris to file path on the way out.
… testing. An export from Premiere from a genuine thing I was editing. In the process of writing the test discovered another bug in the from Kdenlive time string function. Written it to accurately reverse the process in the clock function; written having referred to the source code of mlt. That source code is technically flawed. I believe it isn't written with non-integer frame rates in mind.
Codecov Report
@@ Coverage Diff @@
## master #869 +/- ##
=======================================
Coverage 84.18% 84.18%
=======================================
Files 74 74
Lines 3061 3061
=======================================
Hits 2577 2577
Misses 484 484
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
…n a clip when writing Kdenlive.
… missing references introduced by previous changes.
splidje
force-pushed
the
kdenlive_linear_timewarp
branch
from
163b9f3
to
aa0152e
Compare
ssteinbach
approved these changes
Jan 20, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing Kdenlive, LinearTimewarp effects will be included. If a clip has multiple, their effects are concatenated into a resulting speed.