-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ImageSequenceReference: Added handling for empty target_url_base #891
ImageSequenceReference: Added handling for empty target_url_base #891
Conversation
…equenceReference target_url_base has a trailing / (AcademySoftwareFoundation#890)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're using unittest
style assertions, does this change make sense?
), | ||
) | ||
|
||
assert ref.target_url_for_image_number(0) == 'myfilename.0101.exr' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assert ref.target_url_for_image_number(0) == 'myfilename.0101.exr' | |
self.assertEquals(ref.target_url_for_image_number(0), 'myfilename.0101.exr') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 pytest muscle memory. Fixed.
Codecov Report
@@ Coverage Diff @@
## master #891 +/- ##
=======================================
Coverage 86.65% 86.65%
=======================================
Files 183 183
Lines 17879 17883 +4
Branches 1972 1972
=======================================
+ Hits 15493 15497 +4
Misses 1902 1902
Partials 484 484
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks!
Fixes #890
Summarize your change.
There was a check to see if
target_url_base
ended in a/
to avoid having double-/ in constructed urls. This assumed `target_url_was of at lease length 1. Added a check to not attempt the check if the length is zero.Reference associated tests.
Added test checking generation of bare filenames using
target_url_for_image_number
.