Skip to content

Commit

Permalink
Merge change from PR #863: sanity check ScanlineInput bytesPerLine in…
Browse files Browse the repository at this point in the history
…stead of lineOffset size

This somehow went missing in the cherry-pick/merge.

Signed-off-by: Cary Phillips <cary@ilm.com>
  • Loading branch information
cary-ilm committed May 17, 2021
1 parent 2aac383 commit 7bab6d4
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions OpenEXR/IlmImf/ImfScanLineInputFile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1117,14 +1117,14 @@ void ScanLineInputFile::initialize(const Header& header)
_data->linesInBuffer) / _data->linesInBuffer;

//
// avoid allocating excessive memory due to large lineOffsets table size.
// avoid allocating excessive memory due to large lineOffsets and bytesPerLine table sizes.
// If the chunktablesize claims to be large,
// check the file is big enough to contain the table before allocating memory
// check the file is big enough to contain the lineOffsets table before allocating memory
// in the bytesPerLineTable and the lineOffsets table.
// Attempt to read the last entry in the table. Either the seekg() or the read()
// call will throw an exception if the file is too small to contain the table
//
if (lineOffsetSize > gLargeChunkTableSize)
if (lineOffsetSize * _data->linesInBuffer > gLargeChunkTableSize)
{
Int64 pos = _streamData->is->tellg();
_streamData->is->seekg(pos + (lineOffsetSize-1)*sizeof(Int64));
Expand All @@ -1134,7 +1134,6 @@ void ScanLineInputFile::initialize(const Header& header)

}


size_t maxBytesPerLine = bytesPerLineTable (_data->header,
_data->bytesPerLine);

Expand Down

0 comments on commit 7bab6d4

Please sign in to comment.