A few more NOSONAR suppressions in PyImath

SonarCloud reports expressions such as "self == self" as bugs, but this construct is used in the boost::python template instantiations. Signed-off-by: Cary Phillips <cary@ilm.com>
AcademySoftwareFoundation · Sep 18, 2019 · eae0e33 · eae0e33
1 parent 7995539
commit eae0e33
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/PyIlmBase/PyImath/PyImathFixedMatrix.h b/PyIlmBase/PyImath/PyImathFixedMatrix.h
@@ -502,9 +502,9 @@ template <class T>
 static void add_mod_math_functions(boost::python::class_<FixedMatrix<T> > &c) {
     using namespace boost::python;
     c
-        .def(self % self)
+        .def(self % self) // NOSONAR - suppress SonarCloud bug report.
         .def(self % other<T>())
-        .def(self %= self)
+        .def(self %= self) // NOSONAR - suppress SonarCloud bug report.
         .def(self %= other<T>())
         ;
 }
@@ -513,13 +513,13 @@ template <class T>
 static void add_shift_math_functions(boost::python::class_<FixedMatrix<T> > &c) {
     using namespace boost::python;
     c
-        .def(self << self)
+        .def(self << self) // NOSONAR - suppress SonarCloud bug report.
         .def(self << other<T>())
-        .def(self <<= self)
+        .def(self <<= self) // NOSONAR - suppress SonarCloud bug report.
         .def(self <<= other<T>())
-        .def(self >> self)
+        .def(self >> self) // NOSONAR - suppress SonarCloud bug report.
         .def(self >> other<T>())
-        .def(self >>= self)
+        .def(self >>= self) // NOSONAR - suppress SonarCloud bug report.
         .def(self >>= other<T>())
         ;
 }
@@ -530,15 +530,15 @@ static void add_bitwise_math_functions(boost::python::class_<FixedMatrix<T> > &c
     c
         .def(self & self)
         .def(self & other<T>())
-        .def(self &= self)
+        .def(self &= self) // NOSONAR - suppress SonarCloud bug report.
         .def(self &= other<T>())
         .def(self | self)
         .def(self | other<T>())
-        .def(self |= self)
+        .def(self |= self) // NOSONAR - suppress SonarCloud bug report.
         .def(self |= other<T>())
         .def(self ^ self)
         .def(self ^ other<T>())
-        .def(self ^= self)
+        .def(self ^= self) // NOSONAR - suppress SonarCloud bug report.
         .def(self ^= other<T>())
         ;
 }

diff --git a/PyIlmBase/PyImath/PyImathVec2Impl.h b/PyIlmBase/PyImath/PyImathVec2Impl.h
@@ -1007,7 +1007,7 @@ register_Vec2()
         .def("__mul__", &Vec2_mulM33<T, double>)
         .def("__imul__", &Vec2_imulM33<T, float>, return_internal_reference<>())
         .def("__imul__", &Vec2_imulM33<T, double>, return_internal_reference<>())
-        .def(self / self)
+        .def(self / self) // NOSONAR - suppress SonarCloud bug report.
         .def("__div__", &Vec2_div<T,int>)
         .def("__div__", &Vec2_div<T,float>)
         .def("__div__", &Vec2_div<T,double>)
@@ -1027,8 +1027,8 @@ register_Vec2()
         .def("__itruediv__", &Vec2_idivObj<T>,return_internal_reference<>())
         .def("__xor__", &Vec2_dot<T>)
         .def("__mod__", &Vec2_cross<T>)
-        .def(self == self)
-        .def(self != self)
+        .def(self == self) // NOSONAR - suppress SonarCloud bug report.
+        .def(self != self) // NOSONAR - suppress SonarCloud bug report.
         .def("__eq__", &equal<T,tuple>)
         .def("__ne__", &notequal<T,tuple>)
         .def("__add__", &Vec2_add<T>)