Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openexr 3.1.6 regression #2: ImfDwaCompressor does not compile on ARM v7 due to unguarded use of unavailable AARCH64 intrinsics #1367

Closed
mandree opened this issue Mar 21, 2023 · 0 comments · Fixed by #1368
Closed

openexr 3.1.6 regression #2: ImfDwaCompressor does not compile on ARM v7 due to unguarded use of unavailable AARCH64 intrinsics #1367

mandree opened this issue Mar 21, 2023 · 0 comments · Fixed by #1368

Comments

@mandree
Copy link
Contributor

mandree commented Mar 21, 2023 •
edited

This is similar in nature to #1365, but caused by a different commit, 436fcd2 imported through MR #1323.
Same FreeBSD bug report: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270348#c9

Remedy: We can leverage PR #1366's introduction of IMF_HAVE_NEON_AARCH64 into ImfSimd.h and patch these three files in the same vein:

  • src/lib/OpenEXR/ImfDwaCompressorSimd.h
  • src/lib/OpenEXR/ImfDwaCompressor.cpp
  • src/test/OpenEXRTest/testDwaCompressorSimd.cpp

All seem to #include ImfSimd.h.

@Developer-Ecosystem-Engineering it would be nice if you, too, took notice that there is ARMv7 with 32-bit NEON, where your AARCH64 NEON code won't compile nor execute.
This was referenced Mar 21, 2023
Merged
Merged
mandree referenced this issue Mar 21, 2023
@Developer-Ecosystem-Engineering
Enable fast Huffman & Huffman zig-zag transform for Arm Neon (#1323)
436fcd2 
* Enable fast Huffman decoding on macOS

Enable fast Huffman decoding for macOS (x86 and Apple silicon)

Signed-off-by: Developer Ecosystem Engineering <DeveloperEcosystemEngineering@apple.com>

* Implement Huffman zig-zag transform

Implements Huffman zig-zag transform and 32 to 16 bit floating point

Signed-off-by: Developer Ecosystem Engineering <DeveloperEcosystemEngineering@apple.com>

Signed-off-by: Developer Ecosystem Engineering <DeveloperEcosystemEngineering@apple.com>
cary-ilm pushed a commit that referenced this issue Mar 24, 2023
@mandree
Fix ARMv7 build for DwaCompressor, too. (#1368)
fc3ba3c 
To fix #1367.

Signed-off-by: Matthias Andree <matthias.andree@gmx.de>
cary-ilm pushed a commit to cary-ilm/openexr that referenced this issue Mar 26, 2023
@mandree @cary-ilm
Fix ARMv7 build for DwaCompressor, too. (AcademySoftwareFoundation#1368)
b3637c4 
To fix AcademySoftwareFoundation#1367.

Signed-off-by: Matthias Andree <matthias.andree@gmx.de>
cary-ilm pushed a commit to cary-ilm/openexr that referenced this issue Mar 26, 2023
@mandree @cary-ilm
Fix ARMv7 build for DwaCompressor, too. (AcademySoftwareFoundation#1368)
de7a2dc 
To fix AcademySoftwareFoundation#1367.

Signed-off-by: Matthias Andree <matthias.andree@gmx.de>
cary-ilm pushed a commit that referenced this issue Mar 28, 2023
@mandree @cary-ilm
Fix ARMv7 build for DwaCompressor, too. (#1368)
7cfa661 
To fix #1367.

Signed-off-by: Matthias Andree <matthias.andree@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix ARMv7 build for DwaCompressor, too.
1 participant
@mandree