Enable fast Huffman & Huffman zig-zag transform for Arm Neon #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable fast Huffman decoding for macOS (x86 and Apple silicon) Signed-off-by: Developer Ecosystem Engineering <DeveloperEcosystemEngineering@apple.com>
Implements Huffman zig-zag transform and 32 to 16 bit floating point Signed-off-by: Developer Ecosystem Engineering <DeveloperEcosystemEngineering@apple.com>
|
Ah very nice, thank you! I'm wondering if you have any benchmarking results you might be able to report? I'm sure there's an improvement, but I am curious as to how much of a difference it might be? |
meshula
approved these changes
Jan 11, 2023
kmilos
reviewed
Jan 12, 2023
kmilos
reviewed
Jan 12, 2023
We did see a significant improvement in our own testing. If there are public tests the project would like to see, we are happy to run and provide |
cary-ilm
changed the title
|
Thanks for the contribution! I added "Arm Neon" to the PR title, for clarity. |
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 3, 2023
…SoftwareFoundation#1323) * Enable fast Huffman decoding on macOS Enable fast Huffman decoding for macOS (x86 and Apple silicon) Signed-off-by: Developer Ecosystem Engineering <DeveloperEcosystemEngineering@apple.com> * Implement Huffman zig-zag transform Implements Huffman zig-zag transform and 32 to 16 bit floating point Signed-off-by: Developer Ecosystem Engineering <DeveloperEcosystemEngineering@apple.com> Signed-off-by: Developer Ecosystem Engineering <DeveloperEcosystemEngineering@apple.com>
cary-ilm
pushed a commit
that referenced
this pull request
Mar 5, 2023
* Enable fast Huffman decoding on macOS Enable fast Huffman decoding for macOS (x86 and Apple silicon) Signed-off-by: Developer Ecosystem Engineering <DeveloperEcosystemEngineering@apple.com> * Implement Huffman zig-zag transform Implements Huffman zig-zag transform and 32 to 16 bit floating point Signed-off-by: Developer Ecosystem Engineering <DeveloperEcosystemEngineering@apple.com> Signed-off-by: Developer Ecosystem Engineering <DeveloperEcosystemEngineering@apple.com>
|
This causes build failures on ARMv7, see #1367 |
peterurbanec
added a commit
to peterurbanec/openexr
that referenced
this pull request
Jul 4, 2023
PR AcademySoftwareFoundation#1323 introduces a nested #ifdef check that results in a performance regression on Linux systems that use the clang compiler. This is because the check for __clang__ succeeds, but the nested check for __APPLE__ fails. As a result, the elif case is not taken on Linux. Fixes issue AcademySoftwareFoundation#1479
peterurbanec
added a commit
to peterurbanec/openexr
that referenced
this pull request
Jul 4, 2023
PR AcademySoftwareFoundation#1323 introduces a nested #ifdef check that results in a performance regression on Linux systems that use the clang compiler. This is because the check for __clang__ succeeds, but the nested check for __APPLE__ fails. As a result, the elif case is not taken on Linux. Fixes issue AcademySoftwareFoundation#1479 Signed-off-by: Peter Urbanec <git.user@urbanec.net>
peterurbanec
added a commit
to peterurbanec/openexr
that referenced
this pull request
Jul 4, 2023
PR AcademySoftwareFoundation#1323 introduces a nested #ifdef check that results in a performance regression on Linux systems that use the clang compiler. This is because the check for __clang__ succeeds, but the nested check for __APPLE__ fails. As a result, the elif case is not taken on Linux. Fixes issue AcademySoftwareFoundation#1479 Signed-off-by: Peter Urbanec <peterurbanec@users.noreply.github.com>
cary-ilm
pushed a commit
that referenced
this pull request
Jul 9, 2023
PR #1323 introduces a nested #ifdef check that results in a performance regression on Linux systems that use the clang compiler. This is because the check for __clang__ succeeds, but the nested check for __APPLE__ fails. As a result, the elif case is not taken on Linux. Fixes issue #1479 Signed-off-by: Peter Urbanec <peterurbanec@users.noreply.github.com>
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Jul 25, 2023
…ndation#1480) PR AcademySoftwareFoundation#1323 introduces a nested #ifdef check that results in a performance regression on Linux systems that use the clang compiler. This is because the check for __clang__ succeeds, but the nested check for __APPLE__ fails. As a result, the elif case is not taken on Linux. Fixes issue AcademySoftwareFoundation#1479 Signed-off-by: Peter Urbanec <peterurbanec@users.noreply.github.com>
cary-ilm
pushed a commit
that referenced
this pull request
Jul 31, 2023
PR #1323 introduces a nested #ifdef check that results in a performance regression on Linux systems that use the clang compiler. This is because the check for __clang__ succeeds, but the nested check for __APPLE__ fails. As a result, the elif case is not taken on Linux. Fixes issue #1479 Signed-off-by: Peter Urbanec <peterurbanec@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements fast Huffman on macOS, then builds on top of those changes to enable Huffman zig-zag transform