Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent line terminators (CRLF) #462

Closed
axxel opened this issue Jul 19, 2019 · 4 comments
Closed

Inconsistent line terminators (CRLF) #462

axxel opened this issue Jul 19, 2019 · 4 comments
Labels
Bug A bug in the source code

Comments

@axxel
Copy link
Contributor

axxel commented Jul 19, 2019

Some of the following might be debatable but the CMakeLists.txt is definitively inconsistent with the rest of the repository (and standard practice):

file `find .` | grep CRLF
./ASWF/tsc-meetings/2019-06-13.md:                                      UTF-8 Unicode (with BOM) English text, with CRLF line terminators
./ASWF/tsc-meetings/2019-06-27.md:                                      UTF-8 Unicode (with BOM) English text, with CRLF line terminators
./Contrib/Photoshop/win32/EXRformat-sym.h:                              ASCII C++ program text, with CRLF line terminators
./Contrib/Photoshop/win32/EXRFormat.rc:                                 ASCII C++ program text, with CRLF line terminators
./Contrib/Photoshop/win32/EXRFormat.sln:                                ASCII text, with CRLF line terminators
./PyIlmBase/CMakeLists.txt:                                             ASCII English text, with CRLF line terminators
@meshula meshula added the Bug A bug in the source code label Jul 19, 2019
kdt3rd added a commit to kdt3rd/openexr that referenced this issue Jul 20, 2019
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
kdt3rd added a commit that referenced this issue Jul 20, 2019
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
kdt3rd added a commit to kdt3rd/openexr that referenced this issue Jul 22, 2019
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
kdt3rd added a commit that referenced this issue Jul 22, 2019
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
@kdt3rd
Copy link
Contributor

kdt3rd commented Jul 22, 2019

I think we'll leave the dos-style files alone in the contrib folder, as those are specific for windows, and don't know if visual studio has any particular requirements there. thanks for noticing these inconsistencies!

@kdt3rd kdt3rd closed this as completed Jul 22, 2019
@cary-ilm
Copy link
Member

cary-ilm commented Jul 22, 2019 via email

@meshula
Copy link
Contributor

meshula commented Jul 23, 2019

Side note on Photoshop plugins: OpenEXR is natively supported for import and export in Photoshop, although support is basic. There's this very nice looking plug here - https://www.exr-io.com/ - but it's only available for Windows.

@cary-ilm
Copy link
Member

cary-ilm commented Jul 23, 2019 via email

DominicJacksonBFX pushed a commit to boris-fx/mocha-openexr that referenced this issue Jun 22, 2022
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
DominicJacksonBFX pushed a commit to boris-fx/mocha-openexr that referenced this issue Jun 22, 2022
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in the source code
Projects
None yet
Development

No branches or pull requests

4 participants