Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyIlmBaseConfig not in export set? #604

Closed
cbdwtv opened this issue Oct 29, 2019 · 5 comments · Fixed by #609
Closed

PyIlmBaseConfig not in export set? #604

cbdwtv opened this issue Oct 29, 2019 · 5 comments · Fixed by #609
Assignees
Labels
Needs Discussion To be discussed in the technical steering committee
Milestone

Comments

@cbdwtv
Copy link

cbdwtv commented Oct 29, 2019

Hello,

I am attempting to build the latest commit, (mainly because it had the boost module link fixes), and came across this error in my cmake run:

-- Configuring done
CMake Error: install(EXPORT "PyIlmBase" ...) includes target "PyImath_Python2_7" which requires target "PyIlmBaseConfig" that is not in the export set.

I was wondering what I might be missing to be able to force that to correct itself. I set DPYILMBASE_BUILD_SUPPORT_LIBRARIES=ON in my cmake command hoping that might do it but no change unfortunately.

version layout:
Win 10
boost 1.63
openexr master
python 2.7.14

Was curious if anyone had any advice. TIA

@meshula
Copy link
Contributor

meshula commented Oct 30, 2019

Could you attach your CMakeCache.txt so we can get an idea of what your configuration looks like?

@cbdwtv
Copy link
Author

cbdwtv commented Oct 30, 2019

Definitely! Here is said txt file.
CMakeCache.txt
Thanks

@meshula
Copy link
Contributor

meshula commented Oct 30, 2019

Your file indicates that CMake was able to find boost python, and python 2.7 but it wasn't able to determine specifically what version of python the boost python references. I wonder if our python detection logic does not detect the variant Rez provides? @kdt3rd do you have any thoughts on what might be going on here? I'm having trouble deducing what constructs the string "PyImath_Python2_7"

@cbdwtv
Copy link
Author

cbdwtv commented Oct 30, 2019

I am unsure if it is related but I still ran the ALL_BUILD and INSTALL vcxprojs and it seemed to build/install everything, until I tried using the result to compile alembic against and during that compile it said it was missing "PyIlmBaseConfigInternal.h" and sure enough that file was not in the resulting install dir of OpenEXR but was in its folder where cmake creates it (I assume).

@cary-ilm cary-ilm added the Needs Discussion To be discussed in the technical steering committee label Oct 31, 2019
@kdt3rd
Copy link
Contributor

kdt3rd commented Nov 5, 2019

The config stuff is disabled based on a variable check, except that variable never set, so it will never generate the config files for PyIlmBase. This is left over from the old way of detecting whether or not python is available, where now we just return early and never run this code. I will submit a pull request shortly that will fix this.

kdt3rd added a commit to kdt3rd/openexr that referenced this issue Nov 5, 2019
…nstall

The PyIlmBase install logic was incomplete in cmake. This fixes this:
- computes a relative path from the python paths that can then be used
with CMAKE_INSTALL_PREFIX to install python modules to an appropriate
location (can be manually configured as well, install docs updated)
- Fixes AcademySoftwareFoundation#604, pyilmbaseconfig was also not being installed properly

Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
kdt3rd added a commit that referenced this issue Nov 7, 2019
The PyIlmBase install logic was incomplete in cmake. This fixes this:
- computes a relative path from the python paths that can then be used
with CMAKE_INSTALL_PREFIX to install python modules to an appropriate
location (can be manually configured as well, install docs updated)
- Fixes #604, pyilmbaseconfig was also not being installed properly

Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
kdt3rd added a commit that referenced this issue Nov 8, 2019
The PyIlmBase install logic was incomplete in cmake. This fixes this:
- computes a relative path from the python paths that can then be used
with CMAKE_INSTALL_PREFIX to install python modules to an appropriate
location (can be manually configured as well, install docs updated)
- Fixes #604, pyilmbaseconfig was also not being installed properly

Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
@cary-ilm cary-ilm added this to the v2.5.0 milestone Apr 27, 2020
DominicJacksonBFX pushed a commit to boris-fx/mocha-openexr that referenced this issue Jun 22, 2022
…nstall

The PyIlmBase install logic was incomplete in cmake. This fixes this:
- computes a relative path from the python paths that can then be used
with CMAKE_INSTALL_PREFIX to install python modules to an appropriate
location (can be manually configured as well, install docs updated)
- Fixes AcademySoftwareFoundation#604, pyilmbaseconfig was also not being installed properly

Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Discussion To be discussed in the technical steering committee
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants