Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Bazel CI builds also for pull requests #1083

Conversation

Vertexwahn
Copy link
Contributor

Currently, Bazel CI Builds run only after a merge. Therefore, during the PR is open no Bazel builds are performed an thus no Bazel build errors are shown - only when the PR is merged (when its to late).

Currently, Bazel CI Builds run only after a merge. Therefore, during the PR is open no Bazel build errors are shown - only when the PR is merged (when its to late)

Signed-off-by: Vertexwahn <julian.amann@tum.de>
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The failing windows test is a timeout, seems unrelated to this PR.

@cary-ilm cary-ilm merged commit fb82e4a into AcademySoftwareFoundation:master Jul 9, 2021
@Vertexwahn Vertexwahn deleted the do-bazel-build-on-pull-request branch August 7, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants