Include exported OpenEXR headers with "" instead of <> #1097
Conversation
Signed-off-by: Cary Phillips <cary@ilm.com>
| #include <ImathBox.h> | ||
| #include <half.h> |
There was a problem hiding this comment.
shouldn't these be
<Imath/ImathBox.h>
etc?
There was a problem hiding this comment.
That would seem reasonable, but our CMake files must not be set up that way. The compile flags have -I_build/_deps/imath-src/src/Imath. The Imath headers only end up in the Imath subfolder after the install step. During the build, they're referenced out of the cloned source directory.
If you configure cmake with -DCMAKE_INSTALL_PATH=, then it works for the OpenEXR headers to include <Imath/ImathBox.h>, because the cflags have -I/include.
| @@ -18,9 +18,9 @@ | |||
| #include "ImfUtilExport.h" | |||
|
|
|||
| #include <IexBaseExc.h> | |||
There was a problem hiding this comment.
Yes, missed that one, and another reference to in ImfAttribute.h. I pushed another commit to fix these.
Signed-off-by: Cary Phillips <cary@ilm.com>
|
I'd like to get this in for 3.1, does anyone see any issues? It doesn't resolve everything but at least it makes #includes consistent for OpenEXR library headers. |
Signed-off-by: Cary Phillips cary@ilm.com