Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate dwaCompressionLevel attribute type #1160

Conversation

peterhillman
Copy link
Contributor

Address https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=39342
Ephemeral handling of dwaCompressionLevel attributes in file headers assumed it was always a floatAttribute, causing exception to be thrown and potential memory leak in other cases.

Signed-off-by: Peter Hillman peterh@wetafx.co.nz

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

Copy link
Contributor

@kdt3rd kdt3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, tricksy people, good change

@cary-ilm cary-ilm merged commit 5d67067 into AcademySoftwareFoundation:master Sep 28, 2021
Vertexwahn pushed a commit to Vertexwahn/openexr that referenced this pull request Sep 30, 2021
…n#1160)

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Signed-off-by: Julian Amann <julian.amann@tum.de>
Vertexwahn pushed a commit to Vertexwahn/openexr that referenced this pull request Sep 30, 2021
…n#1160)

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Signed-off-by: Julian Amann <julian.amann@tum.de>
Vertexwahn pushed a commit to Vertexwahn/openexr that referenced this pull request Sep 30, 2021
…n#1160)

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Signed-off-by: Julian Amann <julian.amann@tum.de>
cary-ilm pushed a commit to cary-ilm/openexr that referenced this pull request Oct 14, 2021
cary-ilm pushed a commit that referenced this pull request Oct 24, 2021
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants