Add fast huf decoder #1269
Merged
Add fast huf decoder #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
port of c++ fast huf decoder, other misc performance tweaks. Based on a patch by Phil Barrett Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
meshula
reviewed
Jul 10, 2022
|
yes, there are both the direct huf encode / decode tests in compression.cpp in the core tests (they were pre-existing), and the piz compression tests which exercise this. This should return the performance to at least the same speed as is in the huf decompression in c++ (this is a c-ification of that), although Phil also suggested a couple other small changes like an extension to a faster version of the READ64 to other systems, such as Apple and MSVC. |
meshula
approved these changes
Jul 11, 2022
cary-ilm
pushed a commit
to cary-ilm/openexr
that referenced
this pull request
Mar 3, 2023
* Add fast huf decoder port of c++ fast huf decoder, other misc performance tweaks. Based on a patch by Phil Barrett Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Avoid min / max macros on Win32 Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
cary-ilm
pushed a commit
that referenced
this pull request
Mar 5, 2023
* Add fast huf decoder port of c++ fast huf decoder, other misc performance tweaks. Based on a patch by Phil Barrett Signed-off-by: Kimball Thurston <kdt3rd@gmail.com> * Avoid min / max macros on Win32 Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
port of c++ fast huf decoder, other misc performance tweaks.
Based on a patch by Phil Barrett
Signed-off-by: Kimball Thurston kdt3rd@gmail.com