-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remaining typos #1272
Fix remaining typos #1272
Conversation
Found via `codespell -q 3 -S CHANGES.md,./ASWF/tsc-meetings -L ba,dout,halfs,iif,leapyear,lits,nnumber,offsetp` Signed-off-by: luz paz <luzpaz@github.com>
Substitutes 'compression' for 'compresssion' Signed-off-by: luz paz <luzpaz@github.com>
Found these typos after the fact. Sorry for all the noise. |
src/lib/OpenEXR/ImfRle.cpp
Outdated
@@ -51,7 +51,7 @@ rleCompress (int inLength, const char in[], signed char out[]) | |||
else | |||
{ | |||
// | |||
// Uncompressable run | |||
// Uncompressible run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be incompressible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These all look good, thanks for the cleanup. Two minor suggestions: "uncompressible" is not a word, the proper term is "incompressible", could you kindly make that change?
The code change is fine, it's simply a forward function declaration.
I did not know about codespell, very handy!
@cary-ilm JFYI, you could also add it as a github action: https://github.com/codespell-project/actions-codespell |
Apologies for the annoyance, but that commit needs the "signed-off-by" line similar to the previous one, could you resubmit? And I'll look into adding codespell as an action, thanks. |
Signed-off-by: luz paz <luzpaz@github.com>
My bad, commit has been signed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Yeah, thanks for this. It has inspired me to try codespell and fix some egregious errors in some other code bases as well. :-) |
* Fix remaining typos Found via `codespell -q 3 -S CHANGES.md,./ASWF/tsc-meetings -L ba,dout,halfs,iif,leapyear,lits,nnumber,offsetp` Signed-off-by: luz paz <luzpaz@github.com> * Fix source typos Substitutes 'compression' for 'compresssion' Signed-off-by: luz paz <luzpaz@github.com> * Added requested modifications Signed-off-by: luz paz <luzpaz@github.com> Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
* Fix remaining typos Found via `codespell -q 3 -S CHANGES.md,./ASWF/tsc-meetings -L ba,dout,halfs,iif,leapyear,lits,nnumber,offsetp` Signed-off-by: luz paz <luzpaz@github.com> * Fix source typos Substitutes 'compression' for 'compresssion' Signed-off-by: luz paz <luzpaz@github.com> * Added requested modifications Signed-off-by: luz paz <luzpaz@github.com>
* Fix remaining typos Found via `codespell -q 3 -S CHANGES.md,./ASWF/tsc-meetings -L ba,dout,halfs,iif,leapyear,lits,nnumber,offsetp` Signed-off-by: luz paz <luzpaz@github.com> * Fix source typos Substitutes 'compression' for 'compresssion' Signed-off-by: luz paz <luzpaz@github.com> * Added requested modifications Signed-off-by: luz paz <luzpaz@github.com>
Found via
codespell -q 3 -S CHANGES.md,./ASWF/tsc-meetings -L ba,dout,halfs,iif,leapyear,lits,nnumber,offsetp
Signed-off-by: luz paz luzpaz@github.com