Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining typos #1272

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Fix remaining typos #1272

merged 3 commits into from
Aug 1, 2022

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Jul 31, 2022

Found via codespell -q 3 -S CHANGES.md,./ASWF/tsc-meetings -L ba,dout,halfs,iif,leapyear,lits,nnumber,offsetp

Signed-off-by: luz paz luzpaz@github.com

Found via `codespell -q 3 -S CHANGES.md,./ASWF/tsc-meetings -L ba,dout,halfs,iif,leapyear,lits,nnumber,offsetp`

Signed-off-by: luz paz <luzpaz@github.com>
Substitutes 'compression' for 'compresssion'

Signed-off-by: luz paz <luzpaz@github.com>
@luzpaz
Copy link
Contributor Author

luzpaz commented Jul 31, 2022

Found these typos after the fact. Sorry for all the noise.
Note: there is a source fix in b240ff1. Please review closely.

@@ -51,7 +51,7 @@ rleCompress (int inLength, const char in[], signed char out[])
else
{
//
// Uncompressable run
// Uncompressible run
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be incompressible

Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all look good, thanks for the cleanup. Two minor suggestions: "uncompressible" is not a word, the proper term is "incompressible", could you kindly make that change?

The code change is fine, it's simply a forward function declaration.

I did not know about codespell, very handy!

@luzpaz
Copy link
Contributor Author

luzpaz commented Aug 1, 2022

@cary-ilm JFYI, you could also add it as a github action: https://github.com/codespell-project/actions-codespell

@cary-ilm
Copy link
Member

cary-ilm commented Aug 1, 2022

Apologies for the annoyance, but that commit needs the "signed-off-by" line similar to the previous one, could you resubmit?

And I'll look into adding codespell as an action, thanks.

Signed-off-by: luz paz <luzpaz@github.com>
@luzpaz
Copy link
Contributor Author

luzpaz commented Aug 1, 2022

My bad, commit has been signed.

Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cary-ilm cary-ilm merged commit 635f0b7 into AcademySoftwareFoundation:main Aug 1, 2022
@lgritz
Copy link
Contributor

lgritz commented Aug 1, 2022

Yeah, thanks for this. It has inspired me to try codespell and fix some egregious errors in some other code bases as well. :-)

@luzpaz luzpaz deleted the typos branch August 1, 2022 19:21
darbyjohnston pushed a commit to darbyjohnston/openexr that referenced this pull request Sep 4, 2022
* Fix remaining typos

Found via `codespell -q 3 -S CHANGES.md,./ASWF/tsc-meetings -L ba,dout,halfs,iif,leapyear,lits,nnumber,offsetp`

Signed-off-by: luz paz <luzpaz@github.com>

* Fix source typos

Substitutes 'compression' for 'compresssion'

Signed-off-by: luz paz <luzpaz@github.com>

* Added requested modifications

Signed-off-by: luz paz <luzpaz@github.com>
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
cary-ilm pushed a commit to cary-ilm/openexr that referenced this pull request Mar 3, 2023
* Fix remaining typos

Found via `codespell -q 3 -S CHANGES.md,./ASWF/tsc-meetings -L ba,dout,halfs,iif,leapyear,lits,nnumber,offsetp`

Signed-off-by: luz paz <luzpaz@github.com>

* Fix source typos

Substitutes 'compression' for 'compresssion'

Signed-off-by: luz paz <luzpaz@github.com>

* Added requested modifications

Signed-off-by: luz paz <luzpaz@github.com>
cary-ilm pushed a commit that referenced this pull request Mar 5, 2023
* Fix remaining typos

Found via `codespell -q 3 -S CHANGES.md,./ASWF/tsc-meetings -L ba,dout,halfs,iif,leapyear,lits,nnumber,offsetp`

Signed-off-by: luz paz <luzpaz@github.com>

* Fix source typos

Substitutes 'compression' for 'compresssion'

Signed-off-by: luz paz <luzpaz@github.com>

* Added requested modifications

Signed-off-by: luz paz <luzpaz@github.com>
@cary-ilm cary-ilm added the v3.1.6 label Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants