Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate exrbuild.cpp #1381

Merged
merged 1 commit into from
May 12, 2023
Merged

Conversation

cary-ilm
Copy link
Member

This code appears to have not made it through the v3.0 transition, the associated CMakeList.txt has been lost. There isn't much in the git history describing the program. It seems to do the same thing as "exrmultipart --combine" so its benefit of maintaining it seems minimal.

This code appears to have not made it through the v3.0 transition, the
associated CMakeList.txt has been lost. There isn't much in the git
history describing the program. It seems to do the same thing as
"exrmultipart --combine" so its benefit of maintaining it seems
minimal.

Signed-off-by: Cary Phillips <cary@ilm.com>
@meshula
Copy link
Contributor

meshula commented Apr 13, 2023

Comforming compression across parts seems to be a main goal of this program. @lgritz I speculate that someone at Weta might have run into the "differing compression between parts" bug you ran into in a third party compositing application? @cary-ilm presumably exr multipart --combine enables a "conform compression between parts" operation.

@meshula
Copy link
Contributor

meshula commented Apr 13, 2023

Answering my question ~ exrmultipart --combine doesn't conform compression.

@peterhillman
Copy link
Contributor

exrbuild is no longer useful. I wrote it to generate multipart EXR files for testing early on in the development of OpenEXR-2.0. @pstanczyk turned it exrmultipart and extended its functionality once there was support for raw copying of multipart files.

exrmultipart doesn't modify the compression type. Mixing compression types of different parts is a useful feature of muiltpart OpenEXR files. I wasn't aware of any related bugs.

The exrbuild source code might still serve as useful example code for decompressing and recompressing all OpenEXR part types.

Copy link
Contributor

@kdt3rd kdt3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cary-ilm
Copy link
Member Author

@peterhillman, even though the source may be a useful example, I'm inclined to remove it entirely, since the chance that somebody looking for such an example would actually find it seems slim.

@cary-ilm cary-ilm merged commit cf19b54 into AcademySoftwareFoundation:main May 12, 2023
@cary-ilm cary-ilm added the v3.2.0 label Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants