prepare for new version of libdeflate with thread-safe alloc functions #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mechanism Removes all other calls to internal_exr_alloc if there is a context, allowing full memory allocator overload without setting global functions. Also cleanup code formatting Signed-off-by: Kimball Thurston <kdt3rd@gmail.com>
meshula
reviewed
May 21, 2023
meshula
reviewed
May 21, 2023
meshula
approved these changes
May 21, 2023
There was a problem hiding this comment.
as best as i can tell from visual inspection, you've got libdeflate prior to the mem fn compatibility change and post all wired through to work both ways.
I do wonder if the formatting changes are going to cause clang format to introduce a large number of unwanted changes if anyone runs it? Consequently, I wonder if the clang format file should be relaxed a bit to allow the freer formatting you're using. I prefer the relaxed style you are using FWIW
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all other calls to internal_exr_alloc if there is a context, allowing full memory allocator overload without setting global functions.
Also cleanup code formatting