Switch AVX detection asm to not use an empty clobber list for use with older gcc versions #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h older gcc versions
KevinJW
force-pushed
the
old_gcc_avx_detection
branch
from
c16eae8
to
51073d1
Compare
|
I should probably mention in case i was not clear this can allow the AVX accelerated DWA code to be assembled with gcc 4.1.2 and thus used with Nuke. |
ehanway-ilm
added a commit
that referenced
this pull request
Jul 26, 2016
|
Merged into develop branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it looks like older gcc versions don't like empty clobber lists resulting in an error during configure:
conftest.c:45: error: expected string literal before ')' token
so it is not really testing if we have AVX instructions but the syntax of the version of gcc we have.
This appears to fix it. In particular gcc 4.1.2 for current Nuke
Kevin