Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible fix for #570: avoid writing NaNs into test images #627

Merged
merged 4 commits into from
Jan 24, 2020

Conversation

peterhillman
Copy link
Contributor

I couldn't get a 32bit x86 build working to reproduce #570. However, I think this change may be a fix.

Signed-off-by: Peter Hillman peterh@wetafx.co.nz

…to test images

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 28, 2019

CLA Check
The committers are authorized under a signed CLA.

Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming v.isNan() works, this works :)

@cary-ilm cary-ilm added the Needs Discussion To be discussed in the technical steering committee label Jan 9, 2020
@cary-ilm cary-ilm merged commit fce8c17 into AcademySoftwareFoundation:master Jan 24, 2020
@cary-ilm cary-ilm added this to the v2.5.0 milestone Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Discussion To be discussed in the technical steering committee v2.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants