Add interface includes to IlmBase and OpenEXR #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cary-ilm
added
the
Needs Discussion
meshula
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
lgtm, reference: https://cmake.org/cmake/help/v3.13/command/install.html
kdt3rd
requested changes
Jan 28, 2020
Signed-off-by: Harry Mallon <hjmallon@gmail.com>
|
@kdt3rd will straighten out his CLA and then merge this. |
kdt3rd
approved these changes
Mar 1, 2020
|
Thanks again, sorry for the delay getting this merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for all the great improvements to CMake in 2.4.0! I am having another stab at integrating OpenEXR with the hunter package manager. Hunter tends to be a real work out for CMake implementations so I might have a couple of little tweaks to post.
This one means that
INTERFACE_INCLUDE_DIRECTORIESare populated correctly on the targets in the CMakeXConfig.cmakefiles.