Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Targets and Config and add find_package #639

Merged

Conversation

hjmallon
Copy link
Contributor

This last CMake update splits out the XConfig.cmake and the XTargets.cmake files so that find_dependency lines can be added for the OpenEXRConfig.cmake. The process is described in docs below.

@cary-ilm cary-ilm added the Needs Discussion To be discussed in the technical steering committee label Jan 16, 2020
Signed-off-by: Harry Mallon <hjmallon@gmail.com>
@hjmallon
Copy link
Contributor Author

Rebased on master.

Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cary-ilm
Copy link
Member

We discussed this in the steering committee. This is almost certainly a result of the complication of the top-level "super-build" setup that builds the submodules IlmBase, OpenEXR, PyIlmBase, OpenEXR_Viewers. Our intention with the 3.0 release later in the year is to split these projects into separate github repos, creating proper dependencies between them, which will mean an entire re-vamp of the cmake setup. At this point, this need for a special find_package will change drastically or go away entirely. We'd like to minimize any investment in maintaining the existing setup. This PR adds a level of additional complexity that we'd like to avoid.

@cary-ilm
Copy link
Member

As mentioned above, this entire structure is slated to be retired soon, but this change looks fine for now, so merging it in.

@cary-ilm cary-ilm merged commit 6d26cbf into AcademySoftwareFoundation:master Feb 27, 2020
@cary-ilm cary-ilm added this to the v2.5.0 milestone Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Discussion To be discussed in the technical steering committee v2.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants