Remove OpenEXR_Viewers from the cmake build files and from INSTALL.md #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…L.md instructions. The code is obsolete; it will be removed entirely in the 3.0 release. Signed-off-by: Cary Phillips <cary@ilm.com>
waebbl
reviewed
Mar 5, 2020
| OpenEXR consists of three separate sub-modules - IlmBase, PyIlmBase, | ||
| and OpenEXR - which can be built independently. The repository’s | ||
| top-level CMakeLists.txt defines a *super-project* that builds all | ||
| four modules, and the steps above for running cmake at the top level |
There was a problem hiding this comment.
Shouldn't this then be builds all three modules or just builds all modules?
There was a problem hiding this comment.
Oops, good catch, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is obsolete; it will be removed entirely in the 3.0 release.
Signed-off-by: Cary Phillips cary@ilm.com