Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to make Boost_NO_BOOST_CMAKE a cache variable #698

Merged
merged 2 commits into from
Apr 29, 2020
Merged

Fix to make Boost_NO_BOOST_CMAKE a cache variable #698

merged 2 commits into from
Apr 29, 2020

Conversation

marksisson
Copy link
Contributor

Signed-off-by: Mark Sisson 5761292+marksisson@users.noreply.github.com

Make Boost_NO_BOOST_CMAKE a cache variable, so that it can be changed from command line without editing CMakeLists.txt

Signed-off-by: Mark Sisson <5761292+marksisson@users.noreply.github.com>
@cary-ilm
Copy link
Member

This looks fine to me. @kdt3rd or @meshula, any concerns?

@meshula
Copy link
Contributor

meshula commented Apr 29, 2020

Switching it from hard coded to an option makes sense.

@meshula meshula self-requested a review April 29, 2020 06:37
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cary-ilm cary-ilm merged commit 72cc6e0 into AcademySoftwareFoundation:master Apr 29, 2020
@cary-ilm cary-ilm added this to the v2.5.0 milestone Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants