Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the PyIlmBase tests for the autotools build #747

Merged

Conversation

cary-ilm
Copy link
Member

  • the Makefile.am set the TEST= variable.
  • the py*Test.in files use the shebang #!@python@ to get the right python2/python3
  • configure.ac does chmod +x on the test executable scripts.

With the autotool build, the PyIlmBase tests still require setting LD_LIBRARY_PATH and PYTHONPATH environment variables; they are not set by the "make check". This appears to have always been the case since these files were originally created.

…uild.

Signed-off-by: Cary Phillips <cary@ilm.com>
… build.

* in Makefile.am, the assignment should be TEST=
* in configure.ac, chmod the executable.
* in the .in file, use the #!@python@ directive so it works with python2 and python3.

Signed-off-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Cary Phillips <cary@ilm.com>
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cary-ilm cary-ilm merged commit 58743ee into AcademySoftwareFoundation:master Jun 10, 2020
@cary-ilm cary-ilm added this to the v2.5.2 milestone Jun 11, 2020
@cary-ilm cary-ilm deleted the pyilmbase-test-fix branch May 18, 2021 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants