Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IlmImf: Fix clang compiler warnings #770

Commits on Jun 18, 2020

  1. Merge pull request #1 from AcademySoftwareFoundation/master

    update_arkellr_master_18jun2020
    arkellr committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    5af8855 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2020

  1. IlmImf: Fix misc compiler warnings.

    This allows IlmImf to compile cleanly with clang flags
    -Wall -Wextra -Werror -Wno-unused-parameter
    
    Fixes:
    ImfOpaqueAttribute.h: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]
    const int                   dataSize() const { return _dataSize; }
    ImfDwaCompressor.cpp: error: comparison of integers of different signs: 'long' and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare]
     if (cd->planarUncBufferEnd + dstScanlineSize - _planarUncBuffer[UNKNOWN] > _planarUncBufferSize[UNKNOWN] )
    ImfMisc.cpp: warning: unused variable 'maxBytesPerLine' [-Wunused-variable]
        size_t maxBytesPerLine = bytesPerLineTable (header,
    ImfDeepTiledInputFile.cpp:: error: comparison of integers of different signs: 'Imath_2_5::Int64' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare]
            if(_tileBuffer->dataSize != sizeOfTile)
    
    Signed-off-by: Arkell Rasiah <arasiah@pixsystem.com>
    arkellr committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    e932771 View commit details
    Browse the repository at this point in the history
  2. Switching to current c++ casting style.

    Update based on review comments.
    
    Signed-off-by: Arkell Rasiah <arasiah@pixsystem.com>
    arkellr committed Jun 24, 2020
    Configuration menu
    Copy the full SHA
    233cd09 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2020

  1. Cast to uintptr_t instead of size_t for mask ops on ptrs.

    Addressing reviewer comment.
    
    Signed-off-by: Arkell Rasiah <arasiah@pixsystem.com>
    arkellr committed Jun 25, 2020
    Configuration menu
    Copy the full SHA
    a09e6e7 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2020

  1. Configuration menu
    Copy the full SHA
    8a05edb View commit details
    Browse the repository at this point in the history