IlmImf: Fix clang compiler warnings #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update_arkellr_master_18jun2020
This allows IlmImf to compile cleanly with clang flags
-Wall -Wextra -Werror -Wno-unused-parameter
Fixes:
ImfOpaqueAttribute.h: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]
const int dataSize() const { return _dataSize; }
ImfDwaCompressor.cpp: error: comparison of integers of different signs: 'long' and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare]
if (cd->planarUncBufferEnd + dstScanlineSize - _planarUncBuffer[UNKNOWN] > _planarUncBufferSize[UNKNOWN] )
ImfMisc.cpp: warning: unused variable 'maxBytesPerLine' [-Wunused-variable]
size_t maxBytesPerLine = bytesPerLineTable (header,
ImfDeepTiledInputFile.cpp:: error: comparison of integers of different signs: 'Imath_2_5::Int64' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare]
if(_tileBuffer->dataSize != sizeOfTile)
Signed-off-by: Arkell Rasiah <arasiah@pixsystem.com>
meshula
requested changes
Jun 24, 2020
Update based on review comments. Signed-off-by: Arkell Rasiah <arasiah@pixsystem.com>
arkellr
force-pushed
the
bugfix/arkellr_clang_compiler_warnings
branch
from
547bf98
to
233cd09
Compare
meshula
reviewed
Jun 25, 2020
meshula
requested changes
Jun 25, 2020
Addressing reviewer comment. Signed-off-by: Arkell Rasiah <arasiah@pixsystem.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have a review.
With these updates I can compile the repo cleanly with clang (Xcode10/11) with
"-Wall -Wextra -Werror -Wno-unused-parameter -Wno-unused-function"
NB: -Werror = treat all warnings as errors.
Pretty clean now. Could use the above -W flags for the OSX CI.
Fixes:
ImfOpaqueAttribute.h: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers]
const int dataSize() const { return _dataSize; }
ImfDwaCompressor.cpp: error: comparison of integers of different signs: 'long' and 'size_t' (aka 'unsigned long') [-Werror,-Wsign-compare]
if (cd->planarUncBufferEnd + dstScanlineSize - _planarUncBuffer[UNKNOWN] > _planarUncBufferSize[UNKNOWN] )
ImfMisc.cpp: warning: unused variable 'maxBytesPerLine' [-Wunused-variable]
size_t maxBytesPerLine = bytesPerLineTable (header,
ImfDeepTiledInputFile.cpp:: error: comparison of integers of different signs: 'Imath_2_5::Int64' (aka 'unsigned long') and 'int' [-Werror,-Wsign-compare]
if(_tileBuffer->dataSize != sizeOfTile)