Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 64 bit computation in chunk offset table reconstruction #788

Merged

Conversation

peterhillman
Copy link
Contributor

address https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=24188
ensure 64 bit types are used in all cases when reconstructing offsets
Signed-off-by: Peter Hillman peterh@wetafx.co.nz

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
@lgritz
Copy link
Contributor

lgritz commented Jul 16, 2020

I'm not 100% sure this is right. The "L" suffix implies long, but on some systems long is int, while on other systems, long is bigger than int.

I think ll (LL) is safer to guarantee at least 64 bits.

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Copy link
Member

@cary-ilm cary-ilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cary-ilm cary-ilm merged commit 6cb530d into AcademySoftwareFoundation:master Jul 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants