Fixing Imath automatic install #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen Thompson <oxt3479@rit.edu>
|
A couple gotchas: src/test/OpenEXRFuzzTest/fuzzFile.cpp has #include "../IlmImfTest/TestUtilFStream.h". IexTest/CMakeLists.txt references "IlmBase.Iex", that should now be OpenEXR.Iex. |
|
We should also not be using global include / link directories, but rather per-targets and Imath modules. Additionally, I don't think we should use a git submodule, but rather external project directly... |
|
These changes should not be integrated yet. I will be taking a different approach for the installation in the coming days. |
Signed-off-by: Owen Thompson <oxt3479@rit.edu>
Signed-off-by: Owen Thompson <oxt3479@rit.edu>
Signed-off-by: Owen Thompson <oxt3479@rit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusting the automatic install of Imath to include the correct directories. This could potentially fix the issues with CI.
Signed-off-by: Owen Thompson oxt3479@rit.edu