Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick PRs from master branch which fix issues reported by fuzz tests #875

Merged
merged 23 commits into from
Dec 30, 2020
Merged

Cherry-pick PRs from master branch which fix issues reported by fuzz tests #875

merged 23 commits into from
Dec 30, 2020

Commits on Dec 6, 2020

  1. ignore unused bits in B44 mode detection 

    Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    407216a View commit details
    Browse the repository at this point in the history

  2. apply AcademySoftwareFoundation#832: use unsigned values in shift to … 

    …prevent undefined behavior

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    cb661b2 View commit details
    Browse the repository at this point in the history

  3. apply AcademySoftwareFoundation#818: compute Huf codelengths using 64… 

    … bit to prevent shift overflow

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    1cb83bb View commit details
    Browse the repository at this point in the history

  4. apply AcademySoftwareFoundation#817: double-check unpackedBuffer crea… 

    …ted in DWA uncompress

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    accc96b View commit details
    Browse the repository at this point in the history

  5. apply AcademySoftwareFoundation#820: suppress sanitizer warnings when… 

    … writing invalid enums

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    1632a37 View commit details
    Browse the repository at this point in the history

  6. apply AcademySoftwareFoundation#825: Avoid overflow in calculateNumTi… 

    …les when size=MAX_INT

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @cary-ilm @peterhillman
    cary-ilm authored and peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    10b1c6a View commit details
    Browse the repository at this point in the history

  7. apply AcademySoftwareFoundation#826: restrict maximum tile size to IN… 

    …T_MAX byte limit

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    acececb View commit details
    Browse the repository at this point in the history

  8. apply AcademySoftwareFoundation#827: lighter weight reading of Luma-o… 

    …nly images via RgbaInputFile

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    c72ec27 View commit details
    Browse the repository at this point in the history

  9. refactor channel filling in InputFile API with tiled source 

    Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    f88eea4 View commit details
    Browse the repository at this point in the history

  10. handle edge-case of empty framebuffer 

    Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    6c458f7 View commit details
    Browse the repository at this point in the history

  11. apply AcademySoftwareFoundation#829: fix buffer overflow check in PIZ… 

    … decompression

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    453cc69 View commit details
    Browse the repository at this point in the history

  12. Use Int64 in dataWindowForTile to prevent integer overflow (AcademySo… 

    …ftwareFoundation#831)

* Use Int64 in dataWindowForTile to prevent integer overflow

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>

* use signed 64 bit instead for dataWindow calculation

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>

Co-authored-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman @cary-ilm
    peterhillman and cary-ilm committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    fc439bc View commit details
    Browse the repository at this point in the history

  13. prevent overflow in hufUncompress if nBits is large (AcademySoftwareF… 

    …oundation#836)

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    d63b19d View commit details
    Browse the repository at this point in the history

  14. add sanity check for reading multipart files with no parts (AcademySo… 

    …ftwareFoundation#840)

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    a72909f View commit details
    Browse the repository at this point in the history

  15. reduce B44 _tmpBufferSize (was allocating two bytes per byte) (Academ… 

    …ySoftwareFoundation#843)

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    713d9c4 View commit details
    Browse the repository at this point in the history

  16. check for valid Huf code lengths (AcademySoftwareFoundation#849) 

    * check for valid Huf code lengths
* test non-fast huf decoder in testHuf

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    8debdfa View commit details
    Browse the repository at this point in the history

  17. check 1 part files with 'nonimage' bit have type attribute (AcademySo… 

    …ftwareFoundation#860)

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>

Co-authored-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman @cary-ilm
    peterhillman and cary-ilm committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    888eb71 View commit details
    Browse the repository at this point in the history

  18. Fix overflow computing deeptile sample table size (AcademySoftwareFou… 

    …ndation#861)


Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    b0e080b View commit details
    Browse the repository at this point in the history

  19. re-order shift/compare in FastHuf to prevent undefined shift overflow… 

    … warning (AcademySoftwareFoundation#819)

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>

Co-authored-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman @cary-ilm
    peterhillman and cary-ilm committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    1472578 View commit details
    Browse the repository at this point in the history

  20. more elegant exception handling in exrmaketiled (AcademySoftwareFound… 

    …ation#841)

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    9bda463 View commit details
    Browse the repository at this point in the history

  21. check EXRAllocAligned succeeded to allocate ScanlineInputFile lineBuf… 

    …fers (AcademySoftwareFoundation#844)

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    1327e06 View commit details
    Browse the repository at this point in the history

  22. test channels are DCT compressed before DWA decompression (AcademySof… 

    …twareFoundation#845)

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    e0af7a8 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2020

  1. Merge ABI-compatible changes from AcademySoftwareFoundation#842 

    Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
    @peterhillman
    peterhillman committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    23170c8 View commit details
    Browse the repository at this point in the history