Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick PRs from master branch which fix issues reported by fuzz tests #875

Merged

Conversation

peterhillman
Copy link
Contributor

#817: double-check unpackedBuffer created in DWA uncompress (OSS-fuzz 24854)
#818 compute Huf codelengths using 64 bit to prevent shift overrflow (OSS-fuzz 24831)
#820: suppress sanitizer warnings when writing invalid enums (OSS-fuzz 24969)
#825: Avoid overflow in calculateNumTiles when size=MAX_INT (OSS-fuzz 25297)
#826: restrict maximum tile size to INT_MAX byte limit (OSS-fuzz 25297)
#832: ignore unused bits in B44 mode detection (OSS-fuzz 24787)
#827: lighter weight reading of Luma-only images via RgbaInputFile (OSS-fuzz 25326)
#829: fix buffer overflow check in PIZ decompression (OSS-fuzz 25399, OSS-fuzz 25415)
#830: refactor channel filling in InputFile API with tiled source (OSS-fuzz 25370 , OSS-fuzz 25501)
#831: Use Int64 in dataWindowForTile to prevent integer overflow (OSS-fuzz 25505)
#836: prevent overflow in hufUncompress if nBits is large (OSS-fuzz 25562)
#840: add sanity check for reading multipart files with no parts (OSS-fuzz 25740 , OSS-fuzz 25743)
#841: more elegant exception handling in exrmaketiled (ZhiWei Sun from Topsec Alpha Lab)
#843: reduce B44 _tmpBufferSize (was allocating two bytes per byte) (OSS-fuzz 25913)
#844: check EXRAllocAligned succeeded to allocate ScanlineInputFile lineBuffers (ZhiWei Sun from Topsec Alpha Lab)
#845: test channels are DCT compressed before DWA decompression (ZhiWei Sun from Topsec Alpha Lab)
#849: check for valid Huf code lengths (OSS-fuzz 26229)
#860: check 1 part files with 'nonimage' bit have type attribute (OSS-fuzz 26658)
#861: Fix overflow computing deeptile sample table size (OSS-fuzz 26956)
#863: re-order shift/compare in FastHuf to prevent undefined shift overflow (OSS-fuzz 27409)

Also partial fixes from #842 which do not change the ABI: (OSS-fuzz 25892 , OSS-fuzz 25894)

peterhillman and others added 23 commits December 7, 2020 09:32
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
…prevent undefined behavior

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
… bit to prevent shift overflow

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
…ted in DWA uncompress

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
… writing invalid enums

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
…les when size=MAX_INT

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
…T_MAX byte limit

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
…nly images via RgbaInputFile

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
… decompression

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
…ftwareFoundation#831)

* Use Int64 in dataWindowForTile to prevent integer overflow

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>

* use signed 64 bit instead for dataWindow calculation

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>

Co-authored-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
* check for valid Huf code lengths
* test non-fast huf decoder in testHuf

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
…ftwareFoundation#860)

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>

Co-authored-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
… warning (AcademySoftwareFoundation#819)

Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>

Co-authored-by: Cary Phillips <cary@ilm.com>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Signed-off-by: Peter Hillman <peterh@wetafx.co.nz>
Copy link
Contributor

@meshula meshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that's substantial, thanks for the hard work. Looks good.

@cary-ilm cary-ilm merged commit 0c2b46f into AcademySoftwareFoundation:RB-2.5 Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants