Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace copyright and license in all source and header files #108

Closed
garyo opened this issue Jan 4, 2023 · 3 comments · Fixed by #110
Closed

Replace copyright and license in all source and header files #108

garyo opened this issue Jan 4, 2023 · 3 comments · Fixed by #110
Assignees

Comments

@garyo
Copy link
Contributor

garyo commented Jan 4, 2023

we should probably change the copyright in the header files now that OpenFX is officially an Academy Software Foundation project. I'm happy to do that (using a script). We are using the BSD 3-Clause License.

I assume we should use a modern SPDX-License-Identifier comment block; perhaps something like this:

// Copyright (c) Contributors to the OpenFX project.
// SPDX-License-Identifier: BSD-3-Clause
// https://github.com/AcademySoftwareFoundation/OpenFx

Is that sufficient or should we add the license text itself, a copyright year, or anything else? Is the copyright attribution correct? (I got it from OpenShadingLanguage and OpenColorIO's header is similar.)

By the way, I notice a few // style comments in the headers although we mostly avoid them. I presume we are OK with this now, since // comments were added to ANSI C in 1999. Let me know if you have any problem with that.

@garyo garyo self-assigned this Jan 4, 2023
@revisionfx
Copy link
Contributor

New file can bear new (c)

The theory from our transition research for this, as it would have otherwise required we get a signature from all who may have contributed (and their successors for those who are not alive)
Old files we edit should have 2 lines, (c) OpenFX 2003-2022
(c) new one 2022-23

@jmertic
Copy link

jmertic commented Jan 5, 2023

From our perspective, only the first two lines are required...

// Copyright Contributors to the OpenFX project.
// SPDX-License-Identifier: BSD-3-Clause

Note that I removed the (c) as it's somewhat redundant. Also, adding the year really doesn't add any value, and puts an additional burden on the project to change the year on each file every year.

@garyo
Copy link
Contributor Author

garyo commented Jan 5, 2023

Now being implemented in #110

@garyo garyo linked a pull request Jan 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants