Add improved homa lite redeem match #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 16, 2021 18:32
…c model more easily for HomaLite Added basic unit tests using the feeless mock.
…ailable-staking-balances Added more tests and modified existing tests
…alance, mint/adjust_available_staking_balance will not fail, and will skip the request instead Added corresponding unit test.
…Starting element is read from storage Added unit test to test that function
When updating redeem requests, remember the "next" item Added unit tests to test the new logic
…edeem-match * origin/master: Add more test cases (#1620) bump (#1622) update protocolId and bootnode Fixed a redeem bug and added more Homa lite tests (#1619) Add module asset registry (#1598) MaxAuctions count to 50 (#1617) Cdp Treasury Bench update (#1609) Bump @openzeppelin/contracts from 4.3.2 to 4.3.3 in /ts-tests (#1612) # Conflicts: # modules/homa-lite/src/lib.rs # modules/homa-lite/src/tests_no_fees.rs
xlc
requested changes
Nov 21, 2021
xlc
requested changes
Nov 21, 2021
added 2 commits
November 22, 2021 15:28
…eem request key Iteration now start from and exclude the key Update tests.
iterate_from_next_redeem_request now also updates storage
shaunxw
reviewed
Nov 22, 2021
Modification and removal of redeem requests storage now happens within the same function
wangjj9219
previously approved these changes
Nov 23, 2021
Removed the use of closures Storage mutation and deletion now all happens within the same function and synchronously. `redeem_from_previous_redeem_request` now iterates and redeem requests depending on input parameter.
xlc
previously approved these changes
Nov 24, 2021
xlc
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After redeem requests are processed, the "next" item is stored. When the next mint/unbond/adjust_available_staking happens, redeem requests are iterated from the "next" item. This ensures all redeem requests are "processed" before wrapping around.
Closes #1582