add getEthResources #261
Merged
add getEthResources #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunjizhan
reviewed
Feb 7, 2022
| * @returns The gas used by eth transaction | ||
| */ | ||
| getEthResources = async ( | ||
| transaction: Deferrable<TransactionRequest>, |
There was a problem hiding this comment.
we can make transaction param optional, so then we will be able to use this method directly to calculate eth gasLimit/gasPrice when we don't know the whole transaction
There was a problem hiding this comment.
something like
## when don't know whole TX
const ethGasParams = getEthResources({
transactions: null,
gasLimit,
validUntil,
storageLimit,
})
## when know whole TX
const ethGasParams = getEthResources({
transactions: null
})
There was a problem hiding this comment.
This api is copied from estimateGas and requires transaction parameters.
There was a problem hiding this comment.
If the transaction parameter is not known, then a function can be designed separately.
ntduan
force-pushed
the
add-getEthResources
branch
from
2129a70
to
3be429d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.