Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove exitReason from receipt #963

Merged
merged 4 commits into from
Mar 15, 2024
Merged

remove exitReason from receipt #963

merged 4 commits into from
Mar 15, 2024

Conversation

shunjizhan
Copy link
Collaborator

@shunjizhan shunjizhan commented Mar 15, 2024 •
edited
Loading

fix #961

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 15, 2024
View reviewed changes
packages/eth-providers/src/base-provider.ts
@@ -1746,7 +1745,10 @@
if (
txFromCache &&
await this._isBlockCanonical(txFromCache.blockHash, txFromCache.blockNumber)
) return txFromCache;
) {
delete txFromCache.byzantium;

Check warning

Code scanning / CodeQL

Prototype-polluting assignment Medium

This assignment may alter Object.prototype if a malicious '__proto__' string is injected from
library input
Loading
.
This assignment may alter Object.prototype if a malicious '__proto__' string is injected from
library input
Loading
.
This assignment may alter Object.prototype if a malicious '__proto__' string is injected from
library input
Loading
.
@shunjizhan shunjizhan requested a review from zjb0807 March 15, 2024 07:03
@shunjizhan shunjizhan marked this pull request as ready for review March 15, 2024 07:03
@shunjizhan shunjizhan merged commit ca77ff8 into master Mar 15, 2024
11 checks passed
@shunjizhan shunjizhan deleted the remove-exitreason branch March 15, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjb0807 zjb0807 zjb0807 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to get tx receipt
2 participants
@shunjizhan @zjb0807