fix(styles): fix css is not injected if imported by more than one components #patch #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayhan-ab
requested review from
aris-fm,
yanuaracb,
aziz-zen-ab,
aylwin-AB and
andrinuryawan
aris-fm
approved these changes
Jul 25, 2022
aylwin-AB
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after 0.7.0, fa_icons.css is not injected to head tag and it is imported by several components. this issue is fixed in 0.7.1. Select/index.scss and ValidSelect/index.scss are also imported more than once and it turns out they're not injected as well, so I assume there is a connection between being imported by multiple components and not injected to head tag.
Solution
Let's take
CreatableSelect. instead of importingSelect/index.scssinindex.tsx, we import it inindex.scss. importing in .tsx file will only create one copy of the style, but it won't be injected. importing in .scss file will create duplication after build, but both of them will be injected. currently haven't found a solution that will create only one copy, can be imported by multiple components, but still get injected.