style(Checkbox): limit checkbox clickable area #patch #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayhan-ab
reviewed
Sep 16, 2022
hamdanhanafi
force-pushed
the
fix/limit-checkbox-clickable-area
branch
from
f488906
to
5305f81
Compare
hamdanhanafi
requested review from
rayhan-ab,
aris-fm,
aziz-zen-ab and
yanuaracb
and removed request for
aris-fm,
aziz-zen-ab and
andrinuryawan
aris-fm
approved these changes
Sep 16, 2022
update changelog update CHANGELOG.md fix: update changelog
hamdanhanafi
force-pushed
the
fix/limit-checkbox-clickable-area
branch
from
5305f81
to
f120076
Compare
rayhan-ab
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue clickable area in the checkbox
before
checkbox-before.mp4
after
checkbox-after.mp4
the solution
fix the CSS styles, previously using flex and then changed to use 'inline-flex'
with inline-flex the width of the element label will not fill the whole element on the screen,
just align with an element of the content