Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: end behavior did not override default true #20

Merged
merged 1 commit into from
Oct 26, 2016
Merged

Fix: end behavior did not override default true #20

merged 1 commit into from
Oct 26, 2016

Conversation

kubacka
Copy link
Contributor

@kubacka kubacka commented Oct 25, 2016

After change of default behavior for end there was a bug which made it impossible to change it to false.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d5f2a99 on kubacka:master into 0ec24f6 on Accenture:master.

@chrischang
Copy link
Contributor

👍

Glogo
Glogo approved these changes Oct 26, 2016
View reviewed changes
Copy link
Contributor

@Glogo Glogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works good. Thanks for fixing

@Glogo Glogo merged commit d5f2a99 into Accenture:master Oct 26, 2016
@Glogo
Copy link
Contributor

Glogo commented Oct 26, 2016

updated jsdoc and renamed function name in 119c5dd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Glogo Glogo Glogo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kubacka @coveralls @chrischang @Glogo