Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] retrieving journey by id saves wrong filename when --metadata is used #1397

Closed
2 tasks done
JoernBerkefeld opened this issue Jul 1, 2024 · 2 comments · Fixed by #1426
Closed
2 tasks done

[BUG] retrieving journey by id saves wrong filename when --metadata is used #1397

JoernBerkefeld opened this issue Jul 1, 2024 · 2 comments · Fixed by #1426
Assignees
@JoernBerkefeld
Labels
bug Something isn't working c/journey COMPONENT
Milestone
7.0.4

Comments

@JoernBerkefeld
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

when you try to retrieve a journey with --metadata "journey:id:%23sdfsdfsfdsfsdf" (so with some id) then it will save the file with the id including % in its filename

Expected Behavior

it should work like with retrieve journey "id:%23sdfsdfsfdsfsdf" where it uses the key for the file name

Steps To Reproduce

No response

Version

7.0.3

Environment

No response

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added bug Something isn't working c/journey COMPONENT labels Jul 1, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.1.1 milestone Jul 1, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Jul 1, 2024
@JoernBerkefeld JoernBerkefeld changed the title [BUG] <title> [BUG] retrieving journey by id saves wrong filename when --metadata is used Jul 1, 2024
@JoernBerkefeld
Copy link
Contributor Author

JoernBerkefeld commented Jul 8, 2024 •
edited
Loading

works if:

  • --metadata "journey:id:%23sdfsdfsfdsfsdf"
  • --metadata "journey:id:sdfsdfsfdsfsdf"

does not work if:

  • --metadata "journey:%23sdfsdfsfdsfsdf" (missing id: prefix)

@JoernBerkefeld JoernBerkefeld modified the milestones: 7.1.1, 7.0.4 Jul 8, 2024
JoernBerkefeld added a commit that referenced this issue Jul 8, 2024
@JoernBerkefeld
#1397: retrieving journey with %23 handled more gracefully
4780d3f
@JoernBerkefeld JoernBerkefeld mentioned this issue Jul 8, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Jul 8, 2024 that will close this issue
bug/1397: retrieving journey with %23 handled more gracefully #1426
Merged
4 tasks
@github-actions github-actions bot closed this as completed Jul 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 8, 2024

Closed by #1426.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/journey COMPONENT
Projects
None yet
Milestone
7.0.4
Development

Successfully merging a pull request may close this issue.

bug/1397: retrieving journey with %23 handled more gracefully Accenture/sfmc-devtools
1 participant
@JoernBerkefeld